Centralize running wasi test #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Sturtevant <jstur@microsoft.com>
|
close in favor of #111. It has similar functionality but isn't in the main shim library which is better long term I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #219, I noticed the testing logic is all the same and I was adding functionality in two places.
This is just an example of an idea to re-use some of it. I would like to get others thoughts on if this makes sense of not. I am on the fence... but thought I would share as it similar to #111 (review)
If so we could clean it up, move it somewhere else and maybe improve the function
run_wasi_test<I, E>as it needs instance and the associated item.