Move call of the prestart hooks over to the lib part #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
commented
Jan 31, 2023
| @@ -970,6 +970,19 @@ where | |||
| } | |||
|
|
|||
| let i = self.get_instance(req.get_id())?; | |||
|
|
|||
| if let Some(bundle) = i.cfg.get_bundle() { | |||
There was a problem hiding this comment.
In the case of a cri pause container a new base instance is created without a bundle. I'm not sure I really understand this
There was a problem hiding this comment.
I haven't gone back and looked at the implementation (and it's been long enough I don't have it available in main memory 😄), but we pretend to start a pause container for cri since there's not really anything we can do with it.
|
I just remembered, the prestart hook is a weird one, see this, I'll update the code tomorrow... |
rumpl
force-pushed
the
prestart_hooks
branch
2 times, most recently
from
582afba
to
94f46aa
Compare
Moving this makes pre-start hooks work for all the instances. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
|
Okay with the prestart hook called in the create operation we have networking with docker (tested with wasmedge and spin runtimes) |
cpuguy83
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this makes pre-start hooks work for all the instances.