-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmtime: tidy up #675
wasmtime: tidy up #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Personally I prefer func
over wasm_func_name
, but if you find the latter cleaner, go ahead!
Do you know why CI failed?
probably related to the changes I made. Will take a look |
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
due to the fact that wasip1 and p2 should have their isolated context. Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
9a31589
to
00cfb44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
small refactoring and formating over the wasmtime shim.