Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating .md files as a part of the CNI Website Setup #549

Merged

Conversation

nate-double-u
Copy link
Contributor

Updating .md files, migrating content to the new website.

I think we should wait to merge this PR until the https://cni.dev site is fully up and running for continuity of documentation availability. Note, the new URLs in the README.md files point to where the site will eventually live, so we won't have to re-edit once we get the site up and the URL redirected.

Related issue: #548

@nate-double-u
Copy link
Contributor Author

I'm not able to add reviewers yet, so @-mentioning: @squeed @bboreham @mccv1r0 @dccbw

@nate-double-u nate-double-u mentioned this pull request Nov 9, 2020
6 tasks
pkg/ns/README.md Outdated Show resolved Hide resolved
Removing content and pointing at the new website as a part of the CNI Documentation migration.

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Contributor Author

I've updated the URLs in the README.md files to match the restructuring in PR containernetworking/cni.dev#43 as well.

@nate-double-u nate-double-u marked this pull request as ready for review November 13, 2020 01:48
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>

# Conflicts:
#	plugins/ipam/dhcp/README.md
#	plugins/meta/vrf/README.md
@nate-double-u nate-double-u requested a review from squeed November 13, 2020 01:56
@nate-double-u
Copy link
Contributor Author

I've updated the site to include the info from merge requests #546 and #551.

@nate-double-u
Copy link
Contributor Author

nate-double-u commented Nov 13, 2020

The URL has been wired up, so https://www.cni.dev is live now. I think this PR is ready for merge.

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@nate-double-u
Copy link
Contributor Author

nate-double-u commented Nov 18, 2020

Looks good to me, thanks!

Thanks @bboreham! Just a note: I don't have write access to this repo, so I'm not able to merge this myself.

@squeed squeed merged commit cccf539 into containernetworking:master Nov 18, 2020
@nate-double-u nate-double-u deleted the 548-website-migration branch November 18, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants