-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an install
command
#30
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1ea8c45
to
487d419
Compare
cc65cde
to
4eb5fb7
Compare
In this case, we shouldn't have anything to do. This is needed for `bootc install` which currently sets up these kargs in advance. containers/bootc#30
In this case, we shouldn't have anything to do. This is needed for `bootc install` which currently sets up these kargs in advance. containers/bootc#30
36b3ac5
to
afa55bf
Compare
OK yeah. Let's see if we can support the exciting case of also installing from systems with SELinux disabled... |
b4ecb69
to
a0f9a4e
Compare
OK yeah, this path of testing So, going to instead look at doing CI on Fedora for that. |
cd5a329
to
58eaeed
Compare
In this case, we shouldn't have anything to do. This is needed for `bootc install` which currently sets up these kargs in advance. containers/bootc#30
2bedb76
to
43f9716
Compare
/test all |
Usage example with `/dev/vda` being an extra mounted disk: ``` $ podman run --privileged --pid=host --net=none quay.io/cgwalters/c9s-oscore:latest bootc install /dev/vda ``` Signed-off-by: Colin Walters <walters@verbum.org>
OK, we now have a CI test that proves this works. I think it's about time to get this merged and do further followups (there'll be a lot) as distinct PRs on top of a proven working base. Lifting draft! |
OK no real team on this repo for now so no peer review... |
Usage example with
/dev/vda
being an extra mounted disk:Code and high level design
This merges a lot of code and logic from coreos-installer, coreos-assembler and some bits of fedora-coreos-config.
Unlike ostree,
bootc install
understands and manipulates block devices and bootloaders.Note this obviates much of the need for generating disk images. That said, it may also make sense to have
bootc install generate-iso
.TODO items:
--copy-network
type flows as well as remote config via configmap and secrets #22systemctl switch-root
to container image?)/var
)/usr/lib/bootc/install.cfg
)bootc bootloader update
or so?Closes: #24
Closes: #1