install: Two informational patches #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rhel94 test failure has been fixed by PR #490 |
cgwalters
force-pushed
the
install-more-info
branch
from
8277718
to
734e5e0
Compare
jeckersb
requested changes
Apr 26, 2024
cgwalters
force-pushed
the
install-more-info
branch
2 times, most recently
from
ade67da
to
36fdb37
Compare
|
Man, the signoff thing... |
jeckersb
requested changes
Apr 26, 2024
cgwalters
force-pushed
the
install-more-info
branch
from
36fdb37
to
10a9bd0
Compare
jeckersb
approved these changes
Apr 26, 2024
This is an important thing. Signed-off-by: Colin Walters <walters@verbum.org>
- Label is mandatory so change the API to always take it - Print the label we're using as a description of the fs - Also print the fs type as it's notable info Signed-off-by: Colin Walters <walters@verbum.org>
Let's print out the full command lines for a few select things. I thought about doing this for the `sgdisk` but that feels a bit too verbose right now. Signed-off-by: Colin Walters <walters@verbum.org>
Minor cleanup. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
install-more-info
branch
from
10a9bd0
to
2914c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install: Explicitly print which block setup we're using
This is an important thing.
Signed-off-by: Colin Walters walters@verbum.org
install: Print more information when making filesystems
Signed-off-by: Colin Walters walters@verbum.org