install: Fix install config kargs + to-filesystem #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this got broken in a refactoring; add test coverage. In general all the heavy lifting should move out of `baseline.rs`; a good way to do that is probably to take the next step of making it its own crate that doesn't depend on the bootc core logic perhaps. Closes: containers#570 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
tar: Unconditionally use repo tmpdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this got broken in a refactoring; add
test coverage. In general all the heavy
lifting should move out of
baseline.rs; agood way to do that is probably to take the
next step of making it its own crate that
doesn't depend on the bootc core logic perhaps.
Closes: #570