-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgk/capabilities: modernize, switch to github.com/moby/sys/capability #2167
base: main
Are you sure you want to change the base?
Conversation
Kernel 2.6.32-573.el6, released 2015-07-22 as part of RHEL 6.7, supports cap_last_cap file, so there is no need for a workaround. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
sync.OnceValues is available since Go 1.21 and allows to have less global variables when using sync.Once. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
slices.Sort was introduced in Go 1.21. As the code already imports slices, using slices.Sort allows to have one less package imported. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Replace init and the two global variables with two functions, capList and capStrList, wrapped in sync.OnceValues. This way, there is no runtime overhead of merely including this package, as these functions are executed as needed, not during program initialization. While at it: - rename getCapName to capName for brewity; - use slices.DeleteFunc in capList to filter the slice in place instead of making a copy (less garbage to collect); - improve AllCapabilities documentation. Note that currently neither function returns an error; this is a preparation for the next patch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kolyshkin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
Ephemeral COPR build failed. @containers/packit-build please check. |
This is a fork of the (no longer maintained) github.com/syndtr/gocapability package. For changes since the fork took place, see https://github.com/moby/sys/blob/main/capability/CHANGELOG.md Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
cross build for darwin is failing |
This PR improves pkg/capabilities and switches it to using the new fork. Please see individual commits for details.
Currently a draft pending