Fork opencontainers/runtime-tools to allow us more control

[rhatdan]

We are the only tools that are using runtime-tools, rather then
having to go through the vendoring process, I want to move this
under containers/common.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@mrunalp PTAL at the validate_test.go errors. I am having a hard time debugging. I think the issue is something to do with us vendoring in a version of runtime-spec that is not released.

[mrunalp]

@kolyshkin could you take a look?

[kolyshkin]

Looking...

Would be done to have this split into two parts:

1. Moving files from vendor/github.com/opencontainers/runtime-tools to pkg/runtime-tools, and other changes related to this move (import statements, go.mod/go.sum, vendor/modules.txt, etc).
2. Any further modifications to the (now-local) runtime-tools (can be more than a single commit).

Otherwise those modifications are not described.

[kolyshkin]

I took a look, the Could not read schema from HTTP, response status is 404 Not Found that cause failures in TestJSONSchema test all come from the different version of github.com/xeipuuv/gojsonschema package:

• opencontainers/runtime-tools uses v0.0.0-20170528113821-0c8571ac0ce1
• this PR uses v1.2.0

When I update xeipuuv/gojsonschema to v1.2.0 in upstream runtime-tools, I get the same error.

Unfortunately it's impossible to downgrade that package in this repo, as there are way too many conflicting dependencies, resulting in a downgrade being reverted.

I am currently working on bringing opencontainers/runtime-tools to a better shape and will try to make it work with recent xeipuuv/gojsonschema.

[mrunalp]

I think mainly we just want to import the generate library so we can trim down what we are pulling in.

[kolyshkin]

I think mainly we just want to import the generate library so we can trim down what we are pulling in.

I hope we can avoid forking altogether. Let's see if I can revive this

[kolyshkin]

OK, I have finally figured this out

These failures are happening because new xeipuuv/gojsonschema tries to resolve ids in a schema v1.0.0. Those IDs were removed by opencontainers/runtime-spec#945.

Fixed this in kolyshkin/runtime-tools#1 (the PR against the upstream repo is not even opened yet since I am waiting for them to merge my earlier changes, notably opencontainers/runtime-tools#727 and opencontainers/runtime-tools#728).

[rhatdan]

Ok, I am fine with not merging, if they allow Red Hatters Me, You and Valentin to be administrators of the repo.