libcomposefs: do not override errno #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not override the errno reported by the write_cb as we might lose useful errors like ENOSPC. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgwalters
approved these changes
Jul 30, 2024
| @@ -275,9 +275,9 @@ int lcfs_write(struct lcfs_ctx_s *ctx, void *_data, size_t data_len) | |||
|
|
|||
| if (ctx->write_cb) { | |||
| while (data_len > 0) { | |||
| errno = EIO; | |||
There was a problem hiding this comment.
Hmm, I guess we need to do this because we can't rely on callers setting errno...and indeed in our own code which uses fwrite, it doesn't?
So...okay, is there really no way to get the actual error out of ferror?
There was a problem hiding this comment.
Oh, I guess fwrite is...somewhat expected conventionally to set errno, but it's not standardized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not override the errno reported by the write_cb as we might lose useful errors like ENOSPC.