Check supported version for CreateNamespaces RPC
#1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
feature-version-check
branch
2 times, most recently
from
9756824
to
187ea17
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
+ Coverage 34.10% 34.72% +0.62%
==========================================
Files 13 13
Lines 1126 1126
Branches 389 388 -1
==========================================
+ Hits 384 391 +7
+ Misses 486 474 -12
- Partials 256 261 +5 |
saschagrunert
force-pushed
the
feature-version-check
branch
2 times, most recently
from
fc024cf
to
f5a5e24
Compare
|
/hold |
Merged
saschagrunert
force-pushed
the
feature-version-check
branch
2 times, most recently
from
ade6ea5
to
1ea8116
Compare
We now pre-check if conmon-rs supports the `CreateNamespaces` RPC and return a wrapped defined error if not. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
feature-version-check
branch
from
1ea8116
to
251ff8d
Compare
|
/unhold PTAL @haircommander @rphillips I think after this one we can create a new release. |
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We now pre-check if conmon-rs supports the
CreateNamespacesRPC and return a wrapped defined error if not.Which issue(s) this PR fixes:
Requires #1040
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?