Use default umask 0022
#1153
Merged
Use default umask 0022
#1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under non-reproducible circumstances it can happen that the umask of conmon-rs is set to 0000, which can be a security issue. To avoid that, we now use a default umask and set it directly in the init module. We had a similar fix in CRI-O in cri-o/cri-o#5904, but we have to do it here again because conmon-rs is a direct parent of PID 1. Refers to https://issues.redhat.com/browse/OCPBUGS-8057 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Under non-reproducible circumstances it can happen that the umask of conmon-rs is set to 0000, which can be a security issue. To avoid that, we now use a default umask and set it directly in the init module.
We had a similar fix in CRI-O in cri-o/cri-o#5904, but we have to do it here again because conmon-rs is a direct parent of PID 1.
Which issue(s) this PR fixes:
Refers to https://issues.redhat.com/browse/OCPBUGS-8057
Special notes for your reviewer:
Proposing the same in conmon: containers/conmon#388
Does this PR introduce a user-facing change?