Mention that the go client reuses a running server #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Michaelis <code@mgjm.de>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgjm, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
==========================================
- Coverage 34.00% 33.39% -0.62%
==========================================
Files 13 13
Lines 1135 1135
Branches 392 393 +1
==========================================
- Hits 386 379 -7
- Misses 493 501 +8
+ Partials 256 255 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Mention in the documentation that the go client will connect to an already running server instance.
When a server is already listening in the same
ServerRunDir, the client reuses that server.That also means that other options of the
ConmonServerConfigwill be ignored. The server will keep its settings from the first invocation.Does this PR introduce a user-facing change?