Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix build for multi-arch static binaries #1680

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow multi-arch statically linked binaries for amd64, arm64 and ppc64le.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added multi-arch static binaries for amd64, arm64 and ppc64le.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1680 (1238760) into main (6feea14) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   34.40%   34.31%   -0.09%     
==========================================
  Files          13       13              
  Lines        1151     1151              
  Branches      370      369       -1     
==========================================
- Hits          396      395       -1     
  Misses        525      525              
- Partials      230      231       +1     
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containers).

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit c64098b into containers:main Sep 8, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants