Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture support to get script #1682

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

We now provide support for our new statically linked architectures.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Add support for `amd64`, `arm64` and `ppc64le` as part of the `get` script.

We now provide support for our new statically linked architectures.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

@haircommander @rphillips PTAL. I think we would need a new minor release after that to publish the binaries and re-use them in CRI-O.

@saschagrunert saschagrunert mentioned this pull request Sep 11, 2023
@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@saschagrunert saschagrunert reopened this Sep 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4102ba0 into main Sep 12, 2023
53 checks passed
@saschagrunert saschagrunert deleted the get-arch branch September 12, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants