Fix OOM slice removal race #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 37.53% 37.34% -0.20%
==========================================
Files 15 15
Lines 1268 1264 -4
Branches 414 420 +6
==========================================
- Hits 476 472 -4
+ Misses 526 524 -2
- Partials 266 268 +2 |
Merged
|
@haircommander @rphillips PTAL |
rphillips
reviewed
Aug 1, 2024
saschagrunert
force-pushed
the
oom
branch
3 times, most recently
from
9cad604
to
bbca1a0
Compare
saschagrunert
changed the title
saschagrunert
force-pushed
the
oom
branch
2 times, most recently
from
1018592
to
d6d9a93
Compare
saschagrunert
changed the title
saschagrunert
force-pushed
the
oom
branch
2 times, most recently
from
ff0615e
to
db24515
Compare
If the slice is already removed then we mostly encounter two different errors: - `get next line: No such device (os error 19)` - `open memory events file: /sys/fs/cgroup/test.slice/crio-$ID.scope/memory.events: No such file or directory (os error 2)` To avoid such a race we now check after the errors if the file still exists. If not, then we assume an OOM. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the slice is already removed then we mostly encounter two different errors:
get next line: No such device (os error 19)open memory events file: /sys/fs/cgroup/test.slice/crio-$ID.scope/memory.events: No such file or directory (os error 2)To avoid such a race we now check after the errors if the file still exists. If not, then we assume an OOM.
Which issue(s) this PR fixes:
Fixes cri-o/cri-o#8411
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?