-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default from localhost to 127.0.0.1 #2391
Conversation
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
7c6fc60
to
105eea4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
===========================================
+ Coverage 37.53% 47.89% +10.35%
===========================================
Files 15 121 +106
Lines 1268 4042 +2774
Branches 414 833 +419
===========================================
+ Hits 476 1936 +1460
- Misses 526 1602 +1076
- Partials 266 504 +238 |
/approve |
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bitoku CI seems to hang, do you mind a rebase? |
/close |
@kwilczynski: You can't close an active issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can't /close and /reopen to kick the tires on the CI. 😄 |
What type of PR is this?
/kind other
What this PR does / why we need it:
This PR changes the default tracing endpoint to 127.0.0.1 to align with the cri-o change.
Which issue(s) this PR fixes:
Fixes a part of cri-o/cri-o#7448
Special notes for your reviewer:
Does this PR introduce a user-facing change?