Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default from localhost to 127.0.0.1 #2391

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Aug 20, 2024

What type of PR is this?

/kind other

What this PR does / why we need it:

This PR changes the default tracing endpoint to 127.0.0.1 to align with the cri-o change.

Which issue(s) this PR fixes:

Fixes a part of cri-o/cri-o#7448

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Use 127.0.0.1 as the new default for tracing endpoint.

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.89%. Comparing base (4e0f474) to head (105eea4).
Report is 696 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2391       +/-   ##
===========================================
+ Coverage   37.53%   47.89%   +10.35%     
===========================================
  Files          15      121      +106     
  Lines        1268     4042     +2774     
  Branches      414      833      +419     
===========================================
+ Hits          476     1936     +1460     
- Misses        526     1602     +1076     
- Partials      266      504      +238     

@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

@bitoku CI seems to hang, do you mind a rebase?

@kwilczynski
Copy link
Member

/close

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

@kwilczynski: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Member

Can't /close and /reopen to kick the tires on the CI. 😄

@saschagrunert saschagrunert reopened this Aug 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 957e092 into containers:main Aug 27, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants