Remove token from ContainerIO read_loop #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 34.04% 32.40% -1.65%
==========================================
Files 13 13
Lines 1125 1108 -17
Branches 417 416 -1
==========================================
- Hits 383 359 -24
- Misses 453 467 +14
+ Partials 289 282 -7 |
saschagrunert
changed the title
saschagrunert
force-pushed
the
read-loop-token
branch
4 times, most recently
from
0107f94
to
2ae593f
Compare
This allows the read loop to finish one there is nothing more to read. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
read-loop-token
branch
from
2ae593f
to
8f88d34
Compare
saschagrunert
changed the title
|
@rphillips @haircommander PTAL |
|
hm I would have expected this routine to leak, but the stress memory test isn't failing /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This allows the read loop to finish one there is nothing more to read.
Which issue(s) this PR fixes:
Fixes #738
Special notes for your reviewer:
This is fixing the GitHub actions e2e tests in CRI-O: https://github.com/cri-o/cri-o/actions/runs/3098295877/jobs/5017090180
Does this PR introduce a user-facing change?