Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clap to v3.2.22 #775

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 5, 2022

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

Updating clap to the latest v3 and enabling the deprecated feature.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@saschagrunert saschagrunert changed the title Re-generate Cargo lockfile WIP: Re-generate Cargo lockfile Oct 5, 2022
@saschagrunert saschagrunert changed the title WIP: Re-generate Cargo lockfile Update clap Oct 5, 2022
@saschagrunert saschagrunert force-pushed the lockfile branch 2 times, most recently from 28babc7 to 5278713 Compare October 5, 2022 13:52
@saschagrunert saschagrunert changed the title Update clap Update clap to v3.3.22 Oct 5, 2022
@saschagrunert saschagrunert changed the title Update clap to v3.3.22 Update clap to v3.2.22 Oct 5, 2022
@saschagrunert saschagrunert changed the title Update clap to v3.2.22 WIP: Update clap to v3.2.22 Oct 5, 2022
Updating clap to the latest v3 and enabling the deprecated feature.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert changed the title WIP: Update clap to v3.2.22 Update clap to v3.2.22 Oct 5, 2022
@saschagrunert
Copy link
Member Author

@haircommander @rphillips PTAL

@haircommander
Copy link
Collaborator

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 2cb430c into containers:main Oct 5, 2022
@saschagrunert saschagrunert deleted the lockfile branch October 5, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants