Use stable toolchain for static build
#958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
rust-static
branch
from
41a3af5
to
4d78560
Compare
saschagrunert
changed the title
stable toolchain for static build
saschagrunert
changed the title
stable toolchain for static buildstable toolchain for static build
Ubuntu 22.04 glibc static is not compatible with rustc 1.58.1 (see `ACTION_MSRV_TOOLCHAIN`). Means we now just use the latest one, since the static builds are made for the community. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
rust-static
branch
from
4d78560
to
5671bd0
Compare
|
@haircommander PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Ubuntu 22.04 glibc static is not compatible with rustc 1.58.1 (see
ACTION_MSRV_TOOLCHAIN). Means we now just use the latest one, since the static builds are made for the community.Which issue(s) this PR fixes:
Fixes #957
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?