conmon: do not create oom file under cwd #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Jul 10, 2024
src/cgroup.c
Outdated
| _cleanup_free_ char *ctr_oom_file_path = g_build_filename(base_path, "oom", NULL); | ||
| _cleanup_close_ int ctr_oom_fd = open(ctr_oom_file_path, O_CREAT | O_CLOEXEC, 0666); | ||
| if (ctr_oom_fd < 0) { | ||
| nwarnf("Failed to write oom file to the %s path", path_type); |
There was a problem hiding this comment.
If I read such a message using ctr_oom_file_path would make the most sense as a user is likely not knowing where this path would be and if there is a full file path a user could check this directory quickly.
There was a problem hiding this comment.
replaced path_type with base_path itself
giuseppe
force-pushed
the
create-oom-file-to-bundle-path
branch
from
ec25962
to
3e77d22
Compare
giuseppe
force-pushed
the
create-oom-file-to-bundle-path
branch
from
3e77d22
to
77f8e63
Compare
|
let's try to get ci running to double check this works with crio #515 |
|
@giuseppe can you rebase to get test fixes please? |
instead use the bundle path to create the second (shurgh!) file since this is what CRI-O uses. Closes: containers#504 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
create-oom-file-to-bundle-path
branch
from
77f8e63
to
959cced
Compare
|
rebased |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead use the bundle path to create the second (shurgh!) file since this is what CRI-O uses.
Closes: #504