-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seccomp: support notify listener #627
seccomp: support notify listener #627
Conversation
b649c17
to
1187828
Compare
1ecc6ba
to
09ddd93
Compare
rebased |
/* | ||
* crun - OCI runtime written in C | ||
* | ||
* Copyright (C) 2018, 2019 Giuseppe Scrivano <giuseppe@scrivano.org> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be updated/changed?
|
||
yajl_gen_string (gen, YAJL_STR ("pid"), strlen ("pid")); | ||
yajl_gen_integer (gen, pid); | ||
r = yajl_gen_string (gen, YAJL_STR ("1.0"), strlen ("1.0")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you hard code the version here?
src/libcrun/container.c
Outdated
if (UNLIKELY (r != yajl_gen_status_ok)) | ||
goto exit; | ||
|
||
r = yajl_gen_string (gen, YAJL_STR ("0.2.0"), strlen ("0.2.0")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Majic number, should this be a const?
src/libcrun/container.c
Outdated
if (UNLIKELY (r != yajl_gen_status_ok)) | ||
goto exit; | ||
|
||
r = yajl_gen_string (gen, YAJL_STR ("0.2.0"), strlen ("0.2.0")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic number?
tests/init.c
Outdated
@@ -310,7 +310,7 @@ int main (int argc, char **argv) | |||
|
|||
if (strcmp (argv[1], "check-feature") == 0) | |||
{ | |||
if (argc < 2) | |||
if (argc <= 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be just 3, would be easier to understand.
c978989
to
1cac654
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The OCI runtime specs[1] recently gained the support for seccomp notifications. [1] opencontainers/runtime-spec#1074 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
1cac654
to
9aa382b
Compare
addressed the comments and pushed a new version |
LGTM |
The OCI runtime specs[1] recently gained the support for seccomp
notifications.
[1] opencontainers/runtime-spec#1074
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com