direct: use /proc/self/fd to read xattrs #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
reviewed
Jul 29, 2022
flouthoc
approved these changes
Jul 29, 2022
giuseppe
force-pushed
the
use-proc-read-xattrs
branch
from
f28f1a8
to
1c79442
Compare
instead of using the lgetxattr and llistxattr system calls on the entire file path, use the /proc/self/fd/$FD/$RELATIVE_PATH path instead so that the lookup is relative to the lower dir file descriptor that is already open. Closes: containers#364 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
use-proc-read-xattrs
branch
from
1c79442
to
257d904
Compare
|
I confirm that this patch fixes the issue I'm seeing in #364, thanks! |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using the lgetxattr and llistxattr system calls on the
entire file path, use the /proc/self/fd/$FD/$RELATIVE_PATH path
instead so that the lookup is relative to the lower dir file
descriptor that is already open.
Closes: #364
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com