-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gvisor.dev/gvisor to latest tagged release #249
Conversation
@AkihiroSuda this is #219 rebased with an additional update on top of it |
We'll need to disable f37 packit builds for main branch as well. Could you please add this patch to update packit tasks?
|
fedora 37 only has go 1.19, build will fail after we update gvisor.dev/gvisor as it can only be built with golang 1.20 or newer. Based on a patch from Lokesh Mandvekar Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
It does not seem possible to keep compat with both golang 1.21 and 1.19. golang 1.21 rc releases already landed in rawhide, and current gvisor-tap-vsock git master is not buildable on these systems. This minimum go version update is the first step towards fixing this. containers#232 containers#219 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
google/gvisor@a78e892...99c295d Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
google/gvisor@99c295d...fd277b2 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
The context for the diff you provided does not match what is in git main https://github.com/containers/gvisor-tap-vsock/blob/main/.packit.yaml |
My bad, I wrote it on another branch. Thanks a lot! |
@cfergeau @AkihiroSuda can we get this merged and cut a new release please? |
@@ -17,7 +17,7 @@ jobs: | |||
- name: Set up Go | |||
uses: actions/setup-go@v3 | |||
with: | |||
go-version: 1.18 | |||
go-version: 1.20.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On crc side we need to keep using 0.6.2 until internal build system updated with golang-1.20. |
This will allow building with golang 1.20/1.21, but will break builds with
golang 1.19... If you need to build with 1.19, you will have to keep using
gvisor-tap-vsock 0.6.2
This fixes #232