rpm: gvforwarder subpackage #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
force-pushed
the
gvforwarder-subpackage
branch
from
a485232
to
fb456a9
Compare
This commit places the gvforwarder binary in a new gvforwarder subpackage. This subpackage will be a hard dependency for podman as its required in FCOS. This subpackage will also be a hard dependency for the main package to preserve upgrade path. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
force-pushed
the
gvforwarder-subpackage
branch
from
fb456a9
to
94e0a89
Compare
|
@baude we'll need to have gvisor-tap-vsock have a hard dependency on gvforwarder to preserve the files installed as we're moving the gvforwarder out of the main package. Will not affect fcos as the main package won't get pulled in. |
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Sep 12, 2023
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Sep 12, 2023
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. gvisor-tap-vsock is a separate package for f38, so the subpackage conditional has been adjusted to fit that. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
|
@baude I'll build gvisor and podman (containers/podman#19953) with these changes on Fedora, so you can use them on fcos asap. We should get these PRs in as well before the next release for packit to not blow things up. |
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Sep 12, 2023
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. gvisor-tap-vsock is a separate package for f38, so the subpackage conditional has been adjusted to fit that. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
|
/approve |
Luap99
approved these changes
Sep 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lsm5
added a commit
to lsm5/gvisor-tap-vsock
that referenced
this pull request
Sep 13, 2023
The prior change in containers#268 didn't completely obsolete older builds of gvisor-tap-vsock, causing installation conflicts with the official Fedora builds. This commit should correctly obsolete fedora packages. Ref: https://cirrus-ci.com/task/5730166412935168 Note: To avoid nvr complexity, this commit only fixes the conflicts for official Fedora builds. Any issues with the podman-next copr can be fixed on a case-by-case basis unless an overwhelming amount of people complain. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Sep 13, 2023
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. This change is only intended for f38 and higher. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Sep 13, 2023
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. This change is only intended for f38 and higher. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Sep 13, 2023
With containers/gvisor-tap-vsock#268, gvforwarder is now provided via the subpackage `gvisor-tap-vsock-gvforwarder`. FCOS needs this gvforwarder, hence the hard dependency. This change is only intended for f38 and higher. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
added a commit
to lsm5/gvisor-tap-vsock
that referenced
this pull request
Sep 14, 2023
The prior change in containers#268 didn't completely obsolete older builds of gvisor-tap-vsock, causing installation conflicts with the official Fedora builds. This commit should correctly obsolete fedora packages. Ref: https://cirrus-ci.com/task/5730166412935168 This change should also address installation conflicts in cockpit-reverse dependency tests on podman upstream Ref: https://artifacts.dev.testing-farm.io/716a3cac-ab80-4eb8-921c-da3a784b94fb/ Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit places the gvforwarder binary in a new gvforwarder subpackage. This subpackage will be a hard dependency for podman as its required in FCOS. This subpackage will also be a hard dependency for the main package to preserve upgrade path.