Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Update github.com/insomniacslk/dhcp to latest git main #366

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

cfergeau
Copy link
Contributor

This uses an updated github.com/u-root/uio which fixes building with
GOARCH=loong64

Based on a report from Huang Yang huangyang@loongson.cn

This uses an updated github.com/u-root/uio which fixes building with
GOARCH=loong64

Based on a report from Huang Yang <huangyang@loongson.cn>

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This was implicitly changed in commit df12a45 since go-winio 0.6.2
requires go 1.21.
The insomniakslk/dhcp update makes this change required as it breaks the
build with go 1.20.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Copy link
Member

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this might add support for 龙芯, we can not verify this. So this is review is based on dependencies being updated and compatible, and not an actual use for this secondary architecture.

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau cfergeau merged commit 839f8e5 into containers:main Jul 23, 2024
15 of 19 checks passed
@cfergeau cfergeau deleted the loong64 branch July 23, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants