Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PortsForwarder.Expose() proxy check #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpick
Copy link

@cpick cpick commented Dec 21, 2024

The check for existing proxies entries used local as a key, but they're actually inserted using keys of: key(protocol, local).

This meant that, previously, the check was ineffective and wouldn't reject duplicate forwards.

Copy link
Contributor

openshift-ci bot commented Dec 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpick
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The check for existing `proxies` entries used `local` as a key, but
they're actually inserted using keys of: `key(protocol, local)`.

This meant that, previously, the check was ineffective and wouldn't
reject duplicate forwards.

Signed-off-by: Chris Pick <chris@chrispick.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant