Set default rootless sigstore #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac PTAL |
|
Add |
mtrmac
reviewed
Aug 28, 2020
mtrmac
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Oh… the rest of the client will now need to account for the state that sigstore is no longer “opt-in”. Especially after the /var path is added, the various code paths that assume signatureStorageBase can be nil become dead code.
- As the rest of the code is now, X-R-S-S would never be used, because sigstore is preferred; so we need to either prefer X-R-S-S (RFC: Prefer X-Registry-Supports-Signatures to lookaside #385), or add a new configuration semantics to explicitly say “don’t use sigstore, use X-R-S-S or nothing”. I guess we should just do RFC: Prefer X-Registry-Supports-Signatures to lookaside #385 ; the likelihood that a registry suddenly gains X-R-S-S is getting smaller every month.
QiWang19
force-pushed
the
sigstore
branch
2 times, most recently
from
23f5660
to
2c79bdc
Compare
mtrmac
reviewed
Sep 7, 2020
| The default `sigstore-staging` is `/var/lib/containers/sigstore` from `/etc/containers/registries.d/default.yaml`. | ||
| If the user has no privilege to write the signature to the default sigstore-staging, the YAML format files | ||
| under `$HOME/.config/containers/registries.d` can be configured, otherwise, `$HOME/.local/share/containers/sigstore` will be used. | ||
|
|
||
| ## Examples |
There was a problem hiding this comment.
Consider adding an extra “example” for no configuration.
mtrmac
reviewed
Sep 9, 2020
QiWang19
force-pushed
the
sigstore
branch
4 times, most recently
from
a853970
to
90600f0
Compare
|
@mtrmac PTAL |
mtrmac
reviewed
Sep 10, 2020
Closed
QiWang19
force-pushed
the
sigstore
branch
2 times, most recently
from
f6b9e9e
to
344d6a8
Compare
|
@mtrmac Can I get a review before you leave for PTO? |
mtrmac
reviewed
Sep 17, 2020
|
LGTM after dropping the |
Set default rootless sigstore to ~/.local/share/containers/sigstore if the caller is non-root. Export the func ConfiguredSignatureStorageBase() for Podman image sign implementation. Signed-off-by: Qi Wang <qiwan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default rootless sigstore to ~/.local/share/containers/sigstore if the caller is non-root.
Fix rootless podman push --sign-by.
Signed-off-by: Qi Wang qiwan@redhat.com