OCI source: return error if open blob failed #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
requested changes
Nov 11, 2016
| @@ -186,7 +186,7 @@ type Image interface { | |||
| // ConfigInfo returns a complete BlobInfo for the separate config object, or a BlobInfo{Digest:""} if there isn't a separate object. | |||
| // Note that the config object may not exist in the underlying storage in the return value of UpdatedImage! Use ConfigBlob() below. | |||
| ConfigInfo() BlobInfo | |||
| // ConfigBlob returns the blob described by ConfigInfo, iff ConfigInfo().Digest != ""; nil otherwise. | |||
| // ConfigBlob returns the blob described by ConfigInfo, if ConfigInfo().Digest != ""; nil otherwise. | |||
There was a problem hiding this comment.
This is an unrelated change, and iff is used intentionally ( https://en.wikipedia.org/wiki/If_and_only_if ). Please drop.
Signed-off-by: Ye Yin <eyniy@qq.com>
|
👍 |
mtrmac
approved these changes
Nov 14, 2016
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCI source: return error if open blob failed. This is needed by here
Signed-off-by: Ye Yin eyniy@qq.com