Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature/sigstore.GenerateKeyPair #1810

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Add signature/sigstore.GenerateKeyPair #1810

merged 1 commit into from
Jan 23, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jan 21, 2023

This uses the original cosign private key format, but the API allows us to change our mind in the future (e.g. to something using FIPS-acceptable algorithms).

@vrothberg PTAL.

@mtrmac mtrmac mentioned this pull request Jan 21, 2023
Merged
@mtrmac mtrmac force-pushed the generate-sigstore-key branch 3 times, most recently from 70cdcac to d9dc30c Compare January 21, 2023 20:57
vrothberg
vrothberg approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

Feel free to merge

@mtrmac
Add signature/sigstore.GenerateKeyPair
187ad35 
This uses the original cosign private key format,
but the API allows us to change our mind in the future
(e.g. to something using FIPS-acceptable algorithms).

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac merged commit ed23a00 into containers:main Jan 23, 2023
@mtrmac mtrmac deleted the generate-sigstore-key branch January 23, 2023 15:16
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Jan 23, 2023
@mtrmac
Update c/image after containers/image#1810
981c2fc 
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Jan 23, 2023
@mtrmac
Update c/image after containers/image#1810
48b9d94 
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
doanac pushed a commit to lmp-mirrors/meta-virtualization that referenced this pull request Feb 10, 2023
@zeddii
skopeo: update to 1.11.0
7f37ad2 
We drop a patch that is now part of the release.

Bumping skopeo to version v1.11.0-39-g95680f3c, which comprises the following commits:

    643a2359 Update c/image after containers/image#1816
    2c6e15b5 Run codespell on codebase
    df708d16 [CI:DOCS] Disable dependabot
    2acac8a6 Update module golang.org/x/term to v0.5.0
    f9e2c676 Update golang.org/x/exp digest to 46f607a
    47c7902e Remove unnecessary blank lines
    c1a57ca1 Pre-allocate an array
    2a7b1327 Simplify a condition
    e7ab33e6 Rename a variable to avoid an underscore
    e90c381a Add missing comment punctuation
    70c06b4a Fix, or remove, comments using lint syntax
    9137ac56 Simplify an increment
    efc6e837 Reformat import statements
    a8b9e4e3 Use %w when wrapping errors
    99215e40 Remove a duplicate word
    afa031e8 Use net/netip.Addr instead of net.IP
    891ba3d4 s/interface{}/any/g
    f2b3a9c0 Use golang.org/x/exp
    f1a6d427 Use strings.Cut
    22955d05 go mod tidy -go=1.18
    007f01c6 [CI:BUILD] enable debuginfo for el8 copr builds
    036bf598 [CI:BUILD] copr: fix el8 build and enable debuginfo
    f9406bb0 Cirrus: Use human-readable CI VM Images
    b41b85ab Update module gopkg.in/yaml.v2 to v3
    d2fbec35 Add unit tests for tlsVerifyConfig's yaml.Unmarshaler
    9e24a195 [CI:DOCS] Fix up language in README
    cc958d3e Move to v1.11.1-dev
    9d036f30 Bump to v1.11.0
    83bcd136 [CI:DOCS] Format manual page documents
    afbdaf8e Update module github.com/containers/common to v0.51.0
    c9114248 Update module github.com/containers/image/v5 to v5.24.0
    0fad1193 Add (skopeo generate-sigstore-key)
    48b9d94c Update c/image after containers/image#1810
    80e3fd10 Touch up conscious language issues
    9f04dfde Partially fix removal of temporary data in (make test-system)
    36c480f6 Don't affect $XDG_RUNTIME_DIR of Podman starting the registry
    850bc49d Update module github.com/containers/storage to v1.45.3
    a98c1372 Fix storage.conf setup in test-system
    19815502 Fix (test-integration), in a container without CI
    67a8bef6 Cirrus: Fix c/image CI testing
    63da8390 Bump github.com/containers/ocicrypt from 1.1.6 to 1.1.7
    1fac61ef Cirrus: Add a common intra-test reset function
    292962d3 Fix unnecessary use of podman in CI test
    e239f32a Cirrus: Update to F37 CI VM Images
    ee804858 Cirrus: Remove redundant package install attempt
    0698e82b fix(deps): update module github.com/containers/storage to v1.45.1
    bb1ac893 Add support for Fulcio and Rekor, and --sign-by-sigstore=param-file
    03b5bdec Update c/image after containers/image#1787
    1133a2a3 fix(deps): update module github.com/containers/storage to v1.45.0
    d0cf39d8 Cirrus: Skip OSX CI on release-branches
    f17eafe8 Correctly use the stdout parameter in some places
    58bccf38 fix(deps): update module golang.org/x/term to v0.4.0

Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
doanac pushed a commit to lmp-mirrors/meta-virtualization that referenced this pull request Feb 17, 2023
@zeddii
skopeo: update to 1.11.0
20fde9b 
We drop a patch that is now part of the release.

Bumping skopeo to version v1.11.0-39-g95680f3c, which comprises the following commits:

    643a2359 Update c/image after containers/image#1816
    2c6e15b5 Run codespell on codebase
    df708d16 [CI:DOCS] Disable dependabot
    2acac8a6 Update module golang.org/x/term to v0.5.0
    f9e2c676 Update golang.org/x/exp digest to 46f607a
    47c7902e Remove unnecessary blank lines
    c1a57ca1 Pre-allocate an array
    2a7b1327 Simplify a condition
    e7ab33e6 Rename a variable to avoid an underscore
    e90c381a Add missing comment punctuation
    70c06b4a Fix, or remove, comments using lint syntax
    9137ac56 Simplify an increment
    efc6e837 Reformat import statements
    a8b9e4e3 Use %w when wrapping errors
    99215e40 Remove a duplicate word
    afa031e8 Use net/netip.Addr instead of net.IP
    891ba3d4 s/interface{}/any/g
    f2b3a9c0 Use golang.org/x/exp
    f1a6d427 Use strings.Cut
    22955d05 go mod tidy -go=1.18
    007f01c6 [CI:BUILD] enable debuginfo for el8 copr builds
    036bf598 [CI:BUILD] copr: fix el8 build and enable debuginfo
    f9406bb0 Cirrus: Use human-readable CI VM Images
    b41b85ab Update module gopkg.in/yaml.v2 to v3
    d2fbec35 Add unit tests for tlsVerifyConfig's yaml.Unmarshaler
    9e24a195 [CI:DOCS] Fix up language in README
    cc958d3e Move to v1.11.1-dev
    9d036f30 Bump to v1.11.0
    83bcd136 [CI:DOCS] Format manual page documents
    afbdaf8e Update module github.com/containers/common to v0.51.0
    c9114248 Update module github.com/containers/image/v5 to v5.24.0
    0fad1193 Add (skopeo generate-sigstore-key)
    48b9d94c Update c/image after containers/image#1810
    80e3fd10 Touch up conscious language issues
    9f04dfde Partially fix removal of temporary data in (make test-system)
    36c480f6 Don't affect $XDG_RUNTIME_DIR of Podman starting the registry
    850bc49d Update module github.com/containers/storage to v1.45.3
    a98c1372 Fix storage.conf setup in test-system
    19815502 Fix (test-integration), in a container without CI
    67a8bef6 Cirrus: Fix c/image CI testing
    63da8390 Bump github.com/containers/ocicrypt from 1.1.6 to 1.1.7
    1fac61ef Cirrus: Add a common intra-test reset function
    292962d3 Fix unnecessary use of podman in CI test
    e239f32a Cirrus: Update to F37 CI VM Images
    ee804858 Cirrus: Remove redundant package install attempt
    0698e82b fix(deps): update module github.com/containers/storage to v1.45.1
    bb1ac893 Add support for Fulcio and Rekor, and --sign-by-sigstore=param-file
    03b5bdec Update c/image after containers/image#1787
    1133a2a3 fix(deps): update module github.com/containers/storage to v1.45.0
    d0cf39d8 Cirrus: Skip OSX CI on release-branches
    f17eafe8 Correctly use the stdout parameter in some places
    58bccf38 fix(deps): update module golang.org/x/term to v0.4.0

Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
@zeddii
src/meta-virtualization:skopeo: update to 1.11.0
16be72e 
We drop a patch that is now part of the release.

Bumping skopeo to version v1.11.0-39-g95680f3c, which comprises the following commits:

    643a2359 Update c/image after containers/image#1816
    2c6e15b5 Run codespell on codebase
    df708d16 [CI:DOCS] Disable dependabot
    2acac8a6 Update module golang.org/x/term to v0.5.0
    f9e2c676 Update golang.org/x/exp digest to 46f607a
    47c7902e Remove unnecessary blank lines
    c1a57ca1 Pre-allocate an array
    2a7b1327 Simplify a condition
    e7ab33e6 Rename a variable to avoid an underscore
    e90c381a Add missing comment punctuation
    70c06b4a Fix, or remove, comments using lint syntax
    9137ac56 Simplify an increment
    efc6e837 Reformat import statements
    a8b9e4e3 Use %w when wrapping errors
    99215e40 Remove a duplicate word
    afa031e8 Use net/netip.Addr instead of net.IP
    891ba3d4 s/interface{}/any/g
    f2b3a9c0 Use golang.org/x/exp
    f1a6d427 Use strings.Cut
    22955d05 go mod tidy -go=1.18
    007f01c6 [CI:BUILD] enable debuginfo for el8 copr builds
    036bf598 [CI:BUILD] copr: fix el8 build and enable debuginfo
    f9406bb0 Cirrus: Use human-readable CI VM Images
    b41b85ab Update module gopkg.in/yaml.v2 to v3
    d2fbec35 Add unit tests for tlsVerifyConfig's yaml.Unmarshaler
    9e24a195 [CI:DOCS] Fix up language in README
    cc958d3e Move to v1.11.1-dev
    9d036f30 Bump to v1.11.0
    83bcd136 [CI:DOCS] Format manual page documents
    afbdaf8e Update module github.com/containers/common to v0.51.0
    c9114248 Update module github.com/containers/image/v5 to v5.24.0
    0fad1193 Add (skopeo generate-sigstore-key)
    48b9d94c Update c/image after containers/image#1810
    80e3fd10 Touch up conscious language issues
    9f04dfde Partially fix removal of temporary data in (make test-system)
    36c480f6 Don't affect $XDG_RUNTIME_DIR of Podman starting the registry
    850bc49d Update module github.com/containers/storage to v1.45.3
    a98c1372 Fix storage.conf setup in test-system
    19815502 Fix (test-integration), in a container without CI
    67a8bef6 Cirrus: Fix c/image CI testing
    63da8390 Bump github.com/containers/ocicrypt from 1.1.6 to 1.1.7
    1fac61ef Cirrus: Add a common intra-test reset function
    292962d3 Fix unnecessary use of podman in CI test
    e239f32a Cirrus: Update to F37 CI VM Images
    ee804858 Cirrus: Remove redundant package install attempt
    0698e82b fix(deps): update module github.com/containers/storage to v1.45.1
    bb1ac893 Add support for Fulcio and Rekor, and --sign-by-sigstore=param-file
    03b5bdec Update c/image after containers/image#1787
    1133a2a3 fix(deps): update module github.com/containers/storage to v1.45.0
    d0cf39d8 Cirrus: Skip OSX CI on release-branches
    f17eafe8 Correctly use the stdout parameter in some places
    58bccf38 fix(deps): update module golang.org/x/term to v0.4.0

Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrmac @vrothberg