WIP RFC: docker-daemon ImageTransport #79
Conversation
mtrmac
force-pushed
the
docker-daemon
branch
from
f292486
to
a1ca293
Compare
still using engine-api? |
|
Looking at docker/engine-api#379 , they seem to plan to keep the current version of that repo (but not updating) around. That is good enough for me and now, at least this week. |
great |
mtrmac
force-pushed
the
docker-daemon
branch
from
a1ca293
to
a5a917e
Compare
|
@mtrmac do you think we could have |
| if err != nil { | ||
| return nil, fmt.Errorf("Error initializing docker engine client: %v", err) | ||
| } | ||
| inputStream, err := c.ImageSave(context.TODO(), []string{string(ref)}) // FIXME: ref should be per docker/reference.ParseIDOrReference, and we don't want NameOnly |
From a quick look at the code, I don't see anything and structure looks solid to me. Naming wise, we really need to figure out #72 and make sure this whole thing works ok with both upstream and projectatomic/docker |
Sure, why not. I will change this branch for |
yup |
mtrmac
force-pushed
the
docker-daemon
branch
6 times, most recently
from
c0a3e44
to
4e90072
Compare
mtrmac
force-pushed
the
docker-daemon
branch
from
4e90072
to
6fc00fc
Compare
|
Test failures are probably due to moby/moby#26406 . |
mtrmac
force-pushed
the
docker-daemon
branch
5 times, most recently
from
35cfe56
to
a1b9ed0
Compare
mtrmac
force-pushed
the
docker-daemon
branch
3 times, most recently
from
eae18f1
to
1933fd4
Compare
mtrmac
force-pushed
the
docker-daemon
branch
5 times, most recently
from
fc39bea
to
a2468b3
Compare
This is unfinished, most importantly unable to handle schema1 images in either direction, but an early review would be welcome to avoid potential late surprises and to reveal any stupid bugs I have likely committed.
This adds a docker-daemon: transport, using docker/engine-api/client, creating tarballs for (docker load) on the fly, and storing (docker save) tarballs into a temporary file.
Naming of the refs is unclear as of now; something vague NamedTagged-like; see #72 .