-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: remove centos9 build job #1015
Conversation
Packit ensures c9s buildability, so there's no need for this job. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle yes that is the right thing to do.
However merge protection is not setup for any packit task, mainly because packit tasks are failing to often with random failures (this results in us maintainers ignoring them).
Given nobdy looks after quay.io/libpod/centos9rust image either I am still in favor of merging this so LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
i've begun talks with the go maintainers for centos stream about adding reverse dependency tests on golang rpms before they enter centos stream build environments. So, we should be able to block on packit tasks sometime soon. |
I have not looked at enough to errors to tell but I don't see how blocking golang rpms is helping us here. And our tests contain flakes too of course so the total number of flakes perceived by me looks high. Of course I have no tool to measure the actual numbers. |
uh ya, sorry i meant along with golang, I have plans to check with rust maintainers as well RE: flakes on that PR, I'll report those to packit. RE: dnf install failures, please let me know next time you see them. Quite likely something can be done to fix issues in COPR or how we install packages. |
There are permanently broken on aardvark-dns rawhide currently as an example, https://artifacts.dev.testing-farm.io/d4eac9f2-f05c-4585-8324-0e29a55ed479/ |
Yes, I've learned a few things since the last change to aardvark-dns PR. Things have been fixed in container-selinux to account for this and I'll be replicating that to aardvark-dns.
About merge protection, we'll have to start somewhere. I'll start on container-selinux right away, and soon as we have revdep testing on golang and rust, we can start blocking on build jobs (and later on test jobs) on other repos. |
I am LGTM on this |
was removed in #1098 |
Packit ensures c9s buildability, so there's no need for this job.