Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Fixing panic on layer pull as well as provide mechanism for auth #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sentientmonkey
Copy link

This fixes the panic on layer pull, as well as adding flags for accepting username and password. Since accepting username and password as a command line argument can be a concern on some systems, a prompt flag is provided to capture them over stdin.

Also happy to break these into separate PRs if you'd prefer.

This allows testing private registries that requre basic auth.
Moving to constructor vs. struct to ensure that mutexes have been
properly initialized.
This allows users to provide username and password over stdin vs passing
as commandline flags.
@runcom
Copy link
Member

runcom commented Nov 23, 2016

not sure if this project is still active though, you may want to have a look at skopeo (github.com/projectatomic/skopeo) or its library github.com/containers/image

@sentientmonkey
Copy link
Author

@dgonyeo @philips is this still a maintained project?

@runcom thanks - will check out skopeo - do you know if it provides pulling OCI images?

@runcom
Copy link
Member

runcom commented Nov 24, 2016

It doesn't right now but we're working on it

@sentientmonkey
Copy link
Author

Is there any issue I can track or follow for that support?

Thanks for following up!

@runcom
Copy link
Member

runcom commented Nov 24, 2016

Is there any issue I can track or follow for that support?

unfortunately, that depends on having registries to serve OCI images. No registry out there, afaict, has that support. There's a WIP PR over at distribution/distribution#2076. You can follow that, and soon as something like that lands in the docker registry, we'll implement pulling OCI images from remote registries.

@sentientmonkey
Copy link
Author

@runcom as a heads up, we have launched a registry that does support OCI images with our latest update to the EC2 Container Registry https://aws.amazon.com/about-aws/whats-new/2017/01/amazon-ecr-supports-docker-image-manifest-v2-schema-2/

I was able to test the code above against ECR and it works pulling down images.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants