Skip to content

Commit

Permalink
Cirrus: Use versionable IMAGE_SUFFIX
Browse files Browse the repository at this point in the history
In order for tooling to automatically propose updates to CI VM
image-sets, they must be identifiable by something resembeling
a version.  Additionally, this identifier must sort in a defined
order such that later image updates always follow in order. Lastly,
it's helpful to humans if the identifiers indicate build date/time
as well as OS-release details. Utilize images produced with a new
versioning scheme based on these requirements.

ref: containers/automation_images#247

Also, cleanup a few comments and remove a disused testing task.

Signed-off-by: Chris Evich <cevich@redhat.com>
  • Loading branch information
cevich committed Jan 19, 2023
1 parent db84b2b commit 274ee0d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 33 deletions.
34 changes: 2 additions & 32 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,14 @@ env:

####
#### Cache-image names to test with (double-quotes around names are critical)
#### Comment out fedora-35 for podman 4.x branches.
####
FEDORA_NAME: "fedora-37"
FEDORA_AARCH64_NAME: "${FEDORA_NAME}-aarch64"
PRIOR_FEDORA_NAME: "fedora-36"
UBUNTU_NAME: "ubuntu-2204"
#UBUNTU_NAME: "ubuntu-2204"

# Image identifiers
IMAGE_SUFFIX: "c6447802205601792"
IMAGE_SUFFIX: "c230119-131309-f37-f36-u2204"
# EC2 images
FEDORA_AMI: "fedora-aws-${IMAGE_SUFFIX}"
FEDORA_AARCH64_AMI: "fedora-podman-aws-arm64-${IMAGE_SUFFIX}"
Expand Down Expand Up @@ -855,34 +854,6 @@ buildah_bud_test_task:
always: *int_logs_artifacts


#rootless_gitlab_test_task:
# name: *std_name_fmt
# alias: rootless_gitlab_test
# # Docs: ./contrib/cirrus/CIModes.md
# only_if: &cirrus_cron "${CIRRUS_CRON} == 'main'"
# # Community-maintained downstream test may fail unexpectedly.
# # Ref. repository: https://gitlab.com/gitlab-org/gitlab-runner
# # If necessary, uncomment the next line and file issue(s) with details.
# # allow_failures: $CI == $CI
# depends_on:
# - build
# - rootless_integration_test
# gce_instance: *standardvm
# env:
# <<: *ubuntu_envvars
# TEST_FLAVOR: 'gitlab'
# PRIV_NAME: rootless
# clone_script: *get_gosrc
# setup_script: *setup
# main_script: *main
# always:
# <<: *logs_artifacts
# junit_artifacts:
# path: gitlab-runner-podman.xml
# type: text/xml
# format: junit


upgrade_test_task:
name: "Upgrade test: from $PODMAN_UPGRADE_FROM"
alias: upgrade_test
Expand Down Expand Up @@ -1028,7 +999,6 @@ success_task:
- rootless_remote_system_test
- minikube_test
- buildah_bud_test
#- rootless_gitlab_test
- upgrade_test
- image_build
- meta
Expand Down
2 changes: 1 addition & 1 deletion contrib/cirrus/prebuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ set +a

req_env_vars CI DEST_BRANCH IMAGE_SUFFIX TEST_FLAVOR TEST_ENVIRON \
PODBIN_NAME PRIV_NAME DISTRO_NV AUTOMATION_LIB_PATH \
SCRIPT_BASE CIRRUS_WORKING_DIR FEDORA_NAME UBUNTU_NAME \
SCRIPT_BASE CIRRUS_WORKING_DIR FEDORA_NAME \
VM_IMAGE_NAME

# Defined by the CI system
Expand Down

0 comments on commit 274ee0d

Please sign in to comment.