-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: podman-remote exec: no stderr #8281
Comments
Whoever fixes this: please include the following patch in your PR: diff --git a/test/system/075-exec.bats b/test/system/075-exec.bats
index edd7dedc4..19b4c1afc 100644
--- a/test/system/075-exec.bats
+++ b/test/system/075-exec.bats
@@ -6,8 +6,6 @@
load helpers
@test "podman exec - basic test" {
- skip_if_remote "FIXME: pending #7241"
-
rand_filename=$(random_string 20)
rand_content=$(random_string 50)
|
@mheon this seems like something you should be able to understand/fix? |
2ea9dac |
A friendly reminder that this issue had no activity for 30 days. |
@mheon This seems pretty critical, I have just reproduced. Any idea where this is happening? |
Honestly, no. Too many different errors happening at different places and times in the exec code. |
ping, issue is still present and blocking #8871, which in turn prevents us from checking if #7241 (podman-remote hang) is truly fixed. |
I have some free cycles this afternoon and will have a look. |
Taking another stab. |
Make sure to write error from conmon on the hijacked http connection. This fixes issues where errors were not reported on the client side, for instance, when specified command was not found on the container. To future generations: I am sorry. The code is complex, and there are many interdependencies among the concurrent goroutines. I added more complexity on top but I don't have a good idea of how to reduce complexity in the available time. Fixes: containers#8281 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Make sure to write error from conmon on the hijacked http connection. This fixes issues where errors were not reported on the client side, for instance, when specified command was not found on the container. To future generations: I am sorry. The code is complex, and there are many interdependencies among the concurrent goroutines. I added more complexity on top but I don't have a good idea of how to reduce complexity in the available time. Fixes: containers#8281 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
This is an exact resurrection of #4096. It was working in v2.0, broken in v2.1. It was not caught because the CI test was disabled due to flake #7241 .
In window 1:
$ ./bin/podman system service --timeout=0
Window 2:
Note the missing output: there should be errors from each one. The errors actually appear in window 1 (server):
The text was updated successfully, but these errors were encountered: