Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrMultipleImages does not work #8868

Closed
mtrmac opened this issue Jan 4, 2021 · 0 comments · Fixed by #8875
Closed

ErrMultipleImages does not work #8868

mtrmac opened this issue Jan 4, 2021 · 0 comments · Fixed by #8875
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 4, 2021

From #8176 (comment) , not fixed in #8609:

  • If findImageInRepoTags fails with errors.Wrapf(define.ErrMultipleImages, searchName)
  • The caller in
    if err == nil {
    return inputName, repoImage, nil
    }
    return "", nil, errors.Wrapf(ErrNoSuchImage, err.Error())
    just throws away that value and returns ErrNoSuchImage
  • … causing the error value check in
    if errors.Cause(err) == define.ErrMultipleImages {
    return &entities.BoolReport{Value: true}, nil
    to not trigger, and Exists to return false.

Originally posted by @mtrmac in #8176 (comment)

rhatdan added a commit to rhatdan/podman that referenced this issue Jan 4, 2021
Currently we ignore ErrMultipleImages being returned from findImageInRepoTags.

Fixes: containers#8868

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant