support rootfs contains colon #11912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenk008
force-pushed
the
fix_roofs_path_contains_colon
branch
from
8dd7706
to
e482216
Compare
|
containers/buildah#3581 is required to support rootfs contains colon. |
|
One doubt from original issue #11913 (comment) |
giuseppe
reviewed
Oct 11, 2021
pkg/specgen/specgen.go
Outdated
| parts := strings.SplitN(csc.Rootfs, ":", 2) | ||
| if len(parts) > 1 && parts[1] == "O" { | ||
| parts := strings.Split(csc.Rootfs, ":") | ||
| if len(parts) > 1 && parts[len(parts)-1] == "O" { |
There was a problem hiding this comment.
can we use strings.LastIndex(parts, ":") instead of strings.Split?
There was a problem hiding this comment.
Thanks for your suggestion. I use strings.LastIndex(parts, ":") instead of strings.Split. PTAL.
Fix: containers#11913 Signed-off-by: chenkang <kongchen28@gmail.com>
chenk008
force-pushed
the
fix_roofs_path_contains_colon
branch
from
e482216
to
dd5975f
Compare
|
need rebase to one commit |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenk008, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For now, we can create a container with a readonly rootfs.
podman run --rootfs /some/readonly/path:O echo helloThe rootfs may contains colon
podman run --rootfs /some/a:b/readonly/path:O echo hello, it will failed to parse this directory, the error message is
How to verify it
Run container with a readonly rootfs, and the rootfs path contains colon.
Which issue(s) this PR fixes:
Fixes #11913
Special notes for your reviewer: