Add … push --sign-by-sigstore #17088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
mtrmac
commented
Jan 11, 2023
|
Reworked, together with the c/common part; now the top-level CLI fully creates a This is now ready for review, apart from relying on unmerged dependencies. |
mtrmac
force-pushed
the
sign-by-sigstore
branch
from
9404dc1
to
30d9eb4
Compare
mtrmac
changed the title
mtrmac
force-pushed
the
sign-by-sigstore
branch
3 times, most recently
from
a49e237
to
c4562e1
Compare
mtrmac
force-pushed
the
sign-by-sigstore
branch
3 times, most recently
from
86e2296
to
4d666c3
Compare
mtrmac
force-pushed
the
sign-by-sigstore
branch
7 times, most recently
from
0b158c4
to
cf20b3b
Compare
|
Now ready for review and possible merging. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
vrothberg
added
the
bloat_approved
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtrmac
force-pushed
the
sign-by-sigstore
branch
from
cf20b3b
to
461ebd7
Compare
|
/lgtm |
mtrmac
force-pushed
the
sign-by-sigstore
branch
from
461ebd7
to
21d1af1
Compare
openshift-merge-robot
added
the
needs-rebase
This was referenced Jan 26, 2023
mtrmac
force-pushed
the
sign-by-sigstore
branch
from
21d1af1
to
9a2676f
Compare
openshift-merge-robot
removed
the
needs-rebase
(podman push) and (podman manifest push) now support --sign-by-sigstore=param-file, using the containers-sigstore-signing-params.yaml(5) file format. That notably adds support for Fulcio and Rekor signing. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
sign-by-sigstore
branch
from
9a2676f
to
069edc3
Compare
|
Rebased, tests pass. Please merge. (The changes since the last approved version are in |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman pushandpodman manifest push syncnow support--sign-by-sigstore=param-file,using the
containers-sigstore-signing-params.yaml(5)file format.That notably adds support for Fulcio and Rekor signing.
Depends on
unmergedcontainers/image#1787 ; see that PR for documentation of the YAML file format, as well as example files.See also containers/common#1288 for more discussion about where the interactive prompting pieces should be.
Untested so far.Does this PR introduce a user-facing change?