Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

journald: podman events only show events for current user #17253

Merged
merged 2 commits into from
Jan 27, 2023

Commits on Jan 27, 2023

  1. journald: podman events only show events for current user

    I noticed this while running some things in parallel, podman events
    would show events from other users. Because all events are written to
    the journal everybody can see them. So when we read the journal we must
    filter events for only the current UID.
    
    To reproduce run `podman events` as user then in another window create a
    container as root for example. After this patch it will correctly ignore
    these events from other users.
    
    [NO NEW TESTS NEEDED] I don't think we can test with two users at the same
    time.
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    2ab90f2 View commit details
    Browse the repository at this point in the history
  2. journald: podman logs only show logs for current user

    In the super rare case that there are two containers with the same ID
    for two different users, podman logs with the journald driver would show
    logs from both containers.
    
    [NO NEW TESTS NEEDED] Impossible to reproduce.
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e519910 View commit details
    Browse the repository at this point in the history