Update to github.com/vbauerster/mpb/v8 #17342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
mtrmac
force-pushed
the
mpb
branch
2 times, most recently
from
1392352
to
1ece2f3
Compare
Also update to c/image after containers/image#1821 , so that we don't ship two versions of the package simultaneously. [NO NEW TESTS NEEDED] Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Closed
vrothberg
added
the
bloat_approved
vrothberg
approved these changes
Feb 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In containers/image#1821 , c/image has updated from
github.com/vbauerster/mpb/v7to/v8.Follow suit, so that Podman ships only one copy of that package. Also include the updated version of c/image immediately, so that this doesn’t show up as an increased bloat baseline.
(For the record, I didn’t actually try running the relevant Podman code; the progress bar usage in Podman seems low-risk enough, and unrelated to the changing parts of MPB, to just update.)
Does this PR introduce a user-facing change?