Revert "Revert "pasta: Use two connections instead of three in TCP ra… #17808
Conversation
…nge forward tests"" This reverts commit 1c08f2e: the original failure reported in #17287 persists: [+1306s] not ok 453 podman networking with pasta(1) - TCP translated port range forwarding, IPv4, loopback ... [+1306s] # 2023/03/15 14:33:33 socat[119870] E connect(8, AF=2 127.0.0.1:5127, 16): Interrupted system call [+1306s] # xx [+1306s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv [+1306s] # #| FAIL: Mismatch between data sent and received [+1306s] # #| expected: = xxx [+1306s] # #| actual: xx [+1306s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ so keep two connections instead of three as long as I'm too dumb to figure this out. Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
|
/lgtm Thanks for your prompt action. FWIW, I'm still catching up on flakes from the past few weeks, and notices this one which happened even with the |
openshift-ci
bot
added
the
do-not-merge/hold
Ouch. That's exactly the same issue. On the other hand it looks like reducing those tests to two connections would make the issue less likely to happen while I investigate the root cause. |
|
By extension, then, would bumping to 4 or 5 make it easier to reproduce, hence track down? /approve |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, sbrivio-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
I hope so, thanks for the tip! I actually had half a mind to try to reproduce this again on my setup (which would make things much easier) with some longer loop. I haven't started yet, but indeed increasing the number of connections is something I'm going to try. |
github-actions
bot
added
the
locked - please file new issue/PR
…nge forward tests""
This reverts commit 1c08f2e: the original failure reported in #17287 persists:
[+1306s] not ok 453 podman networking with pasta(1) - TCP translated port range forwarding, IPv4, loopback
...
[+1306s] # 2023/03/15 14:33:33 socat[119870] E connect(8, AF=2 127.0.0.1:5127, 16): Interrupted system call
[+1306s] # xx
[+1306s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+1306s] # #| FAIL: Mismatch between data sent and received
[+1306s] # #| expected: = xxx
[+1306s] # #| actual: xx
[+1306s] # #^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
so keep two connections instead of three as long as I'm too dumb to figure this out.
Does this PR introduce a user-facing change?