Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to containers/image v5, support manifest lists #4310

Merged
merged 7 commits into from
Oct 29, 2019
Merged

Move to containers/image v5, support manifest lists #4310

merged 7 commits into from
Oct 29, 2019

Commits on Oct 29, 2019

  1. bump containers/image to v5.0.0, buildah to v1.11.4 

    Move to containers/image v5 and containers/buildah to v1.11.4.

Replace an equality check with a type assertion when checking for a
docker.ErrUnauthorizedForCredentials in `podman login`.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    a4a70b4 View commit details
    Browse the repository at this point in the history

  2. Add e2e tests for manifest list support 

    Test that when we pull using tag or digest references from locations
that are manifest lists, that we can inspect using the references that
we used for pulling, that the tags show up in the RepoTag list when we
inspect an image that was pulled using a tag, and that the list and
instance digests always both show up in the RepoDigest list.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    05c65e8 View commit details
    Browse the repository at this point in the history

  3. image: don't get confused by lists 

    When an image can be opened as an ImageSource but not an Image, handle
the case where it's an image list all by itself, the case where it's an
image for a different architecture/OS combination, or the case where
it's both.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    8033573 View commit details
    Browse the repository at this point in the history

  4. pull/create: add --override-arch/--override-os flags 

    Add --override-arch and --override-os as hidden flags, in line with the
global flag names that skopeo uses, so that we can test behavior around
manifest lists without having to conditionalize more of it by arch.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    b9313d3 View commit details
    Browse the repository at this point in the history

  5. API: report multiple digests for images 

    Be prepared to report multiple image digests for images which contain
multiple manifests but, because they continue to have the same set of
layers and the same configuration, are considered to be the same image.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    07195ff View commit details
    Browse the repository at this point in the history

  6. images: distinguish between tags and digests 

    Generate an image's RepoDigests list using all applicable digests, and
refrain from outputting a digest in the tag column of the "images"
output.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed Oct 29, 2019
    2 Configuration menu
    Copy the full SHA
    248bb61 View commit details
    Browse the repository at this point in the history

  7. Set default seccomp.json file for podman play kube 

    Currently podman play kube is not using the system default seccomp.json file.
This PR will use the default or override location for podman play.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
    @rhatdan @nalind
    rhatdan authored and nalind committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    66c126d View commit details
    Browse the repository at this point in the history