generate systemd: quote arguments with whitespace #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@mheon a late candidate for 2.0. @edsantiago, I need a head nod from you before we can merge. Can you think of a case where the changes could lead to a regression? |
|
LGTM |
edsantiago
reviewed
Aug 18, 2020
vrothberg
force-pushed
the
fix-7285
branch
3 times, most recently
from
7d0ad7c
to
d70727d
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
Nice catch, LGTM |
|
LGTM |
|
No, it's the CI hang. @vrothberg you need to rebase on master, I'm sorry. |
Make sure that arguments with whitespace are properly quoted so they are interpreted as one (and not multiple ones) by systemd. Now `-e tz="america/new york"` will be generated as `-e "tz=america/new york"`. The quotes are moving but the argument is still correct. Fixes: containers#7285 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
merge me :) |
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that arguments with whitespace are properly quoted so they are
interpreted as one (and not multiple ones) by systemd.
Now
-e tz="america/new york"will be generated as-e "tz=america/new york".The quotes are moving but the argument is still correct.
Fixes: #7285
Signed-off-by: Valentin Rothberg rothberg@redhat.com