Implement SD-NOTIFY proxy in conmon #7607
Conversation
|
@haircommander @edsantiago @rhatdan PTAL This is goochjj#1 rebased against master I can squash if you'd like. |
goochjj
force-pushed
the
libpod-sd-notify-with-conmon
branch
2 times, most recently
from
c0b0ab9
to
7406483
Compare
|
Tests are likely failing because of conmon dependency. |
|
@cevich @haircommander We need an updated conmon to test with. |
|
pr has to be merged first :) |
It's possible to hijack the new image build process, since it all happens inside a PR (merging isn't necessary). It can also be run manually/locally...but the docs PR isn't merged yet.. Though this is probably "the hard way" for anyone who hasn't done it. Merge the change (here) first, then do the tests in a separate PR is the lazy/easy way to do this. |
|
There's a chance we dragged in a newer Conmon as part of the new CI changes from @cevich - a rebase might make this pass? |
I'm showing |
goochjj
force-pushed
the
libpod-sd-notify-with-conmon
branch
from
7406483
to
39f627a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: goochjj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander PTAL |
|
LGTM |
|
@goochjj Could you rebase. @haircommander Do we have the support in conmon at this point? |
|
yes though I don't know if the VMs have the correct version |
|
@haircommander What is the minimum version requirement? |
This leverages conmon's ability to proxy the SD-NOTIFY socket. This prevents locking caused by OCI runtime blocking, waiting for SD-NOTIFY messages, and instead passes the messages directly up to the host. Signed-off-by: Joseph Gooch <mrwizard@dok.org>
goochjj
force-pushed
the
libpod-sd-notify-with-conmon
branch
from
39f627a
to
7c4a4c4
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
|
Replaced by #8508 |
github-actions
bot
added
the
locked - please file new issue/PR
Requires containers/conmon#182
Sets up bind mounts for a sd-notify socket, and passes it to the env of the OCI runtime. NOTIFY_SOCKET is removed from the environment so the OCI runtime does not process the socket, conmon proxies it instead.
Discussion #6688 #7316