Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign multi-arch images #7718

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

QiWang19
Copy link
Contributor

@QiWang19 QiWang19 commented Sep 21, 2020

podman image sign handles muti-arch images.
--all option to create signature for each manifest from the image manifest list.

close: https://bugzilla.redhat.com/show_bug.cgi?id=1770037

Signed-off-by: Qi Wang qiwan@redhat.com

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@QiWang19 QiWang19 marked this pull request as draft September 21, 2020 22:12
@QiWang19 QiWang19 force-pushed the sign-multi-arch branch 3 times, most recently from 9cead62 to 1f60cd6 Compare September 25, 2020 19:09
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Oct 27, 2020

@QiWang19 Needs a rebase.

@rhatdan
Copy link
Member

rhatdan commented Oct 27, 2020

@QiWang19 Needs a rebae.

@QiWang19
Copy link
Contributor Author

I'll rework this one after #7357 being merged.

@QiWang19 Needs a rebae.

@QiWang19 QiWang19 marked this pull request as ready for review December 10, 2020 20:19
@QiWang19 QiWang19 changed the title [wip]Sign multi-arch images Sign multi-arch images Dec 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@QiWang19 QiWang19 removed the stale-pr label Dec 10, 2020
@QiWang19
Copy link
Contributor Author

@mtrmac PTAL.

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, just some nits.

cmd/podman/images/sign.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
cmd/podman/images/sign.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
pkg/domain/infra/abi/images.go Outdated Show resolved Hide resolved
podman image sign handles muti-arch images.
--all option to create signature for each manifest from the image manifest list.

Signed-off-by: Qi Wang <qiwan@redhat.com>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TomSweeneyRedHat
Copy link
Member

LGTM
Very nice work @QiWang19 !

@zhangguanzhang
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2020
@zhangguanzhang
Copy link
Collaborator

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit 36bec38 into containers:master Dec 12, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants