Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The slirp4netns sandbox requires pivot_root #8852

Merged
merged 1 commit into from
Dec 30, 2020
Merged

The slirp4netns sandbox requires pivot_root #8852

merged 1 commit into from
Dec 30, 2020

Conversation

afbjorklund
Copy link
Contributor

Disable the sandbox, when running on rootfs

Closes #8846

@afbjorklund
The slirp4netns sandbox requires pivot_root
25b7198 
Disable the sandbox, when running on rootfs

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@mheon
Copy link
Member

mheon commented Dec 29, 2020

LGTM
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 30, 2020

/lgtm
/hold
/approve

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, mheon, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund
Copy link
Contributor Author

Once slirp4netns grows a "--no-pivot" feature, that could be detected and used instead.
Currently it is just assumed that using "--enable-sandbox" requires pivot_root support...

Note that this shouldn't change anything for the default podman setup (not running off rootfs)
It is only required when wanting to use rootless/slirp4netns and also running from a RAM disk

@rhatdan
Copy link
Member

rhatdan commented Dec 30, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit c6c9b45 into containers:master Dec 30, 2020
@edsantiago edsantiago mentioned this pull request Jan 4, 2021
Closed
@edsantiago edsantiago mentioned this pull request Jan 19, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman run fails on tinycore
5 participants
@afbjorklund @mheon @rhatdan @openshift-ci-robot @openshift-merge-robot