Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite copy-up to use buildah Copier #9308

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Rewrite copy-up to use buildah Copier #9308

merged 1 commit into from
Feb 11, 2021

Commits on Feb 10, 2021

  1. Rewrite copy-up to use buildah Copier 

    The old copy-up implementation was very unhappy with symlinks,
which could cause containers to fail to start for unclear reasons
when a directory we wanted to copy-up contained one. Rewrite to
use the Buildah Copier, which is more recent and should be both
safer and less likely to blow up over links.

At the same time, fix a deadlock in copy-up for volumes requiring
mounting - the Mountpoint() function tried to take the
already-acquired volume lock.

Fixes containers#6003

Signed-off-by: Matthew Heon <mheon@redhat.com>
    @mheon
    mheon committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ea910fc View commit details
    Browse the repository at this point in the history