*: switch from pkg/errors to Go 1.13+ error wrapping #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion was mostly done using the go-wrap-to-percent-w tool. The manual parts were: 1. Replacing errors.Cause with errors.Is. 2. Auditing returned errors to not provide extra context (e.g. os.Open and ioutils.ReadFile already have the failed operation (open, read etc.) and the file name in the error message). 3. Changing go.mod to specify 1.13 (as this is the version that introduced the features used here). 4. make vendor. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
vrothberg
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Loving it, thank you, @kolyshkin (and @AkihiroSuda).
@giuseppe PTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion was mostly done using the wonderful go-wrap-to-percent-w tool by @AkihiroSuda.
The manual parts were:
Replacing
errors.Causewitherrors.Is.Auditing returned errors to not provide extra context (e.g.
os.Openand
ioutils.ReadFilealready have the failed operation (open, readetc.) and the file name in the error message).
Changing go.mod to specify 1.13 (as this is the version that
introduced the features used here).
make vendor.