Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support copy multi arch instance #2445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support copy multi arch instance #2445

wants to merge 1 commit into from

Conversation

cleverhu
Copy link

@cleverhu cleverhu commented Oct 28, 2024 •
edited
Loading

support copy multi arch instance, this PR must work with containers/image#2612

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

mtrmac
mtrmac requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Similarly to c/image, all existing options must keep working.

Also compare previous #1987, that probably discusses relevant concerns; I didn’t now go back to re-read that.

cmd/skopeo/copy.go Show resolved Hide resolved
cmd/skopeo/copy.go Outdated Show resolved Hide resolved
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Oct 29, 2024
@cleverhu cleverhu force-pushed the main branch 2 times, most recently from f6926e4 to 5a33835 Compare October 30, 2024 01:58
support copy multi arch instance
0f73399 
Signed-off-by: cleverhu <zhubai.hsp@xuelanyun.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleverhu @mtrmac