Modify skopeo tests #399
Merged
Modify skopeo tests #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umohnani8
force-pushed
the
oci_name
branch
4 times, most recently
from
859d507
to
751abd9
Compare
|
@mtrmac PTAL |
mtrmac
reviewed
Aug 26, 2017
integration/copy_test.go
Outdated
|
|
||
| // docker v2s2 -> OCI image layout without image name | ||
| ociDest = "busybox-latest-noimage" | ||
| assertSkopeoFails(c, ".*Error writing manifest: cannot save image with empty image.ref.name.*", "copy", "docker://busybox:latest", "oci:"+ociDest) |
There was a problem hiding this comment.
Testing this scenario might detect problems earlier if it were a unit test in the oci transport; testing that here doesn’t hurt, sure; but shouldn’t the busybox-latest-noimage directory also be cleaned up? The error is reported in PutManifest, which means PutBlob has already written files into the directory AFAICS.
(Even the old code should have used ioutil.TempDir instead of writing to the current directory, but that’s of course independent of this PR and not a blocker for it.)
mtrmac
reviewed
Aug 31, 2017
vendor.conf
Outdated
| @@ -1,5 +1,6 @@ | |||
| github.com/urfave/cli v1.17.0 | |||
| github.com/containers/image master | |||
| # github.com/containers/image master | |||
There was a problem hiding this comment.
Nit: please drop this comment.
There was a problem hiding this comment.
whoops, my bad. Fixed.
|
@umohnani8 Please update the expected error message: |
The oci name changes in containers/image caused the skopeo test to fail Signed-off-by: umohnani8 <umohnani@redhat.com>
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oci name changes in containers/image containers/image#318 caused the skopeo test to fail
Signed-off-by: umohnani8 umohnani@redhat.com